1751644 - Custom-styled <select> options have much less padding than other options, on linux with dom.forms.select.customstyling enabled

Status: VERIFIED FIXED

(Core :: Widget: Gtk, defect)

Description

[Daniel Holbert [:dholbert]]

STR:

1. In Firefox (or Nightly) on Linux, set pref dom.forms.select.customstyling to true and restart Firefox to let that change take effect.
2. Load this testcase:

data:text/html,<select><option>1</option><option>2</option><option style="background:red">3

2. Click to open the dropdown menu.

ACTUAL RESULTS:
Option 3 has much less padding (it's less indented) as compared to the other options.

EXPECTED RESULTS:
Consistent padding. I've only customized the background on that option; I wouldn't expect that to affect layout/positioning.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: screenshot

Comment 2

[Daniel Holbert [:dholbert]]

(I think bug 1406865 comment 10 explains approximately why this happens right now.)

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1751644 - Don't shrink padding of non-native menulist items. r=dao

Native ones also have a big-ish padding (set by the theme).

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/329994288845
Don't shrink padding of non-native menulist items. r=stransky

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/329994288845

Comment 6

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2022-01-23 Nightly build on Linux x86_64(Ubuntu 20.04). I can confirm this is fixed on Firefox 99.0b8(20220328190900) and Nightly 100.a1(20220328213646) on Linux x86_64(Ubuntu 20.04).