1779538 - Convert ChromeUtils.importESModule at top-level in ESM to static import in ./mach esmify

Status: RESOLVED FIXED

(Core :: XPConnect, task, P1)

Description

[Tooru Fujisawa [:arai]]

./mach esmify --imports detects ChromeUtils.import and Cu.import at the top-level and replace it with static import if the file is .sys.mjs.

This doesn't cover the following case:

1. ./mach esmify --convert A.jsm converts A.jsm into A.sys.mjs
2. ./mach esmify --imports . rewrites ChromeUtils.import("A.jsm") at top-level of B.jsm with ChromeUtils.importESModule("A.sys.mjs")
3. ./mach esmify --convert B.jsm converts B.jsm into B.sys.mjs
4. ./mach esmify --imports . to rewrite consumers in B.sys.mjs

At step 4, ChromeUtils.importESModule("A.sys.mjs") is not handled, but it should be replaced with static import, given it's at the top-level.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1779538 - Rewrite ChromeUtils.importESModule with static import in sys.mjs. r?yulia!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aa33ade6d8e5
Rewrite ChromeUtils.importESModule with static import in sys.mjs. r=yulia

Comment 3

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/aa33ade6d8e5