1800286 - Switch select in selectAudioOutput() prompt to multi-line

Status: RESOLVED FIXED

(Firefox :: Site Permissions, enhancement, P2)

Description

[Karl Tomlinson (:karlt)]

As suggested in bug 1712892 comment 3.

Perhaps this could stay single line if there is a matching deviceId passed to selectAudioOutput() (and the permission has been revoked).

Comment 1

[Karl Tomlinson (:karlt)]

Attachment: dark-unfocused-richlistbox.png

With a dark theme, the selected item in the richlistbox is identified by subtle background color changes, but bug 1809745 will make the selected speaker stand out.

Comment 2

[Karl Tomlinson (:karlt)]

Attachment: Bug 1800286 move some repeated prompt set-up to listDevices() r?pbz

Comment 3

[Karl Tomlinson (:karlt)]

Attachment: Bug 1800286 use MozMenuList.appendItem() r?pbz

This will permit sharing code for a RichListBox.appendItem() call in a
subsequent patch.

Depends on D182316

Comment 4

[Karl Tomlinson (:karlt)]

Attachment: Bug 1800286 use a richlistbox for speaker selection r?pbz

Setting the selectedItem of a richlistbox to null is a no-op and leaves
previous state remaining, so the selectedIndex is explicitly set instead of
depending on connectedCallback() to do so.

Depends on D182317

Comment 5

[Karl Tomlinson (:karlt)]

https://treeherder.mozilla.org/jobs?repo=try&revision=c34ca935f04ab0d0775c2f6c9f1d27ccaa2142de

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b1b5300ef409
move some repeated prompt set-up to listDevices() r=pbz
https://hg.mozilla.org/integration/autoland/rev/b1640784291e
use MozMenuList.appendItem() r=pbz
https://hg.mozilla.org/integration/autoland/rev/f877f5be86e7
use a richlistbox for speaker selection r=pbz,desktop-theme-reviewers,dao

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/b1b5300ef409
https://hg.mozilla.org/mozilla-central/rev/b1640784291e
https://hg.mozilla.org/mozilla-central/rev/f877f5be86e7