1824613 - Convert toolkit/mozapps/extensions to ES modules

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, task, P3)

Description

[Mark Banner (:standard8)]

As part of the ongoing work, we should convert toolkit/mozapps/extensions to ES modules.

I think there's no workers involved here, so there shouldn't be any blockers. There is a guide for the transition here.

Comment 1

[Lata]

Hey! I would like to work on this. Can I go ahead?

Comment 2

[Mark Banner (:standard8)]

Despite my comment 0, I think this needs to be worked on by someone familiar with the add-on manager.

I have recently realised that the modules here are unloaded in tests via Cu.unload and this is not supported in ES modules.

Hence alternatives need figuring out and the developers who are familiar with the code would be best to do that.

Comment 3

[Lata]

Alright.

Comment 4

[Mark Banner (:standard8)]

Attachment: Bug 1824613 - Convert addonManager.js to an ES module. r?#extension-reviewers!

Also renames to avoid conflicts with AddonManager.jsm once that is converted.

Comment 5

[Mark Banner (:standard8)]

Attachment: Bug 1824613 - Convert most of toolkit/mozapps/extensions/ to ES modules. r?#extension-reviewers!

Depends on D179818

Comment 6

[Mark Banner (:standard8)]

Attachment: Bug 1824613 - Convert consumers of toolkit/mozapps/extensions/ to import ES modules directly. r?#extension-reviewers!

Depends on D179819

Comment 7

[Mark Banner (:standard8)]

Try push: https://treeherder.mozilla.org/jobs?repo=try&revision=da80f866a1afd98bff0c3426cec41d234b77236b

I've split the remaining files out to bug 1836480 and bug 1836482 as they need extra work/thinking about.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1f3e15de9c08
Convert addonManager.js to an ES module. r=extension-reviewers,robwu
https://hg.mozilla.org/integration/autoland/rev/3a9f92ff530f
Convert most of toolkit/mozapps/extensions/ to ES modules. r=extension-reviewers,robwu
https://hg.mozilla.org/integration/autoland/rev/73920a1d9785
Convert consumers of toolkit/mozapps/extensions/ to import ES modules directly. r=extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,sync-reviewers,sgalich,bytesized,robwu,skhamis

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/1f3e15de9c08
https://hg.mozilla.org/mozilla-central/rev/3a9f92ff530f
https://hg.mozilla.org/mozilla-central/rev/73920a1d9785