1844238 - Don't duplicate role definitions

Status: RESOLVED FIXED

(Core :: Disability Access APIs, task)

Description

[James Teh [:Jamie]]

Currently, we have to define roles in both accessible/base/Role.h and accessible/interfaces/nsIAccessibleRole.idl and ensure they are kept in sync. We even duplicate the comments. Ideally, we would only need to maintain one or the other.

Comment 1

[James Teh [:Jamie]]

Attachment: Bug 1844238 part 1: Change includes of Role.h to mozilla/a11y/Role.h.

Role.h will soon be generated, but it is generated within the obj dir, so local includes won't work.
Our C++ style guide says we should prefer exported includes wherever possible anyway.

This was done with this shell command inside the accessible/ directory:

sed -i 's,#include "Role.h",#include "mozilla/a11y/Role.h",' `git grep -l '#include "Role.h"'`

Comment 2

[James Teh [:Jamie]]

Attachment: Bug 1844238 part 2: Generate Role.h from nsIAccessibleRole.idl.

This eliminates duplication.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a490408f57c8
part 1: Change includes of Role.h to mozilla/a11y/Role.h. r=eeejay
https://hg.mozilla.org/integration/autoland/rev/6a9aca2a1b89
part 2: Generate Role.h from nsIAccessibleRole.idl. r=eeejay

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/a490408f57c8
https://hg.mozilla.org/mozilla-central/rev/6a9aca2a1b89