1851323 - Table layout is broken on certain web page

Status: VERIFIED FIXED

(Core :: Layout, defect, P3)

Description

[Alice0775 White]

Attachment: screenshot

Steps to reprodue:

1. Open https://academysoftwarefoundation.github.io/EncodingGuidelines/tests/greyramp-osx/compare.html?.colortrc

Actual Results:
Table row height is larger than Firefox117.0 and Chrome.
Thus the gap between video elements is larger.

Expected Results:
The gap is almost 0.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=6d877fdb9a1e892fe6528a26aab81b53cfae55c5&tochange=d6760db62dc1cc0831c09c42f086cf57d1c2bf48

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:m_kato, since you are the author of the regressor, bug 1719535, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Makoto Kato [:m_kato]]

IS x AL shouldn't break opportunity on UAX14 spec (LB29).

Comment 3

[Makoto Kato [:m_kato]]

Ah, this was https://github.com/unicode-org/icu4x/pull/3548.

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Makoto, do you know when is that patch end up in FF?

Comment 5

[Makoto Kato [:m_kato]]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #4)

Makoto, do you know when is that patch end up in FF?

Although this will fixed by ICU4X 1.3, it can import the fix since this issue is data file only. So I will fix this soon.

Comment 6

[Makoto Kato [:m_kato]]

https://treeherder.mozilla.org/jobs?repo=try&selectedTaskRun=EitEhUUARFOgc8m4fEoYvw.0&revision=3d1ad6eb494a79e00e8d8cf2bc7a61bcdbbb0eac

Comment 7

[Makoto Kato [:m_kato]]

Attachment: Bug 1851323 - Apply the latest line break rules. r=TYLin

Since some issues such as bug 1851323 are fixed by ICU4X 1.3's data rule file,
I would like to apply it to get feedback in Gecko.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a953dc51ae0f
Apply the latest line break rules. r=TYLin

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/a953dc51ae0f

Comment 10

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Reproduced the issue with 119.0a1 (2023-09-02) on Windows 10x64. The table row line height was bigger.
Verified fixed with Firefox 119.0 on Windows 10x64, macOS 12 and Ubuntu 22 following STR from comment 0. The table row height is correctly displayed.