1854032 - Enable intl.icu4x.segmenter.enabled by default

Status: RESOLVED FIXED

(Core :: Internationalization, task)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Currently, intl.icu4x.segmenter.enabled is enabled on Nightly only. [1] This bug can be used as a meta bugs tracking the necessary works before we enable it by default.

[1] https://searchfox.org/mozilla-central/rev/7499890dc8f116a9e40f4a689a251a0311a9f461/modules/libpref/init/StaticPrefList.yaml#7232-7236

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Makoto, I'm making bug 1848049 blocking this one. Feel free to adjust, or add new bugs. Thanks!

Comment 3

[Makoto Kato [:m_kato]]

Remove dependency of bug 1848049 via https://bugzilla.mozilla.org/show_bug.cgi?id=1848049#c22

Comment 4

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Thanks Makoto! All the dependent bugs are resolved, so it looks like we are ready to ship if there is no regression after landing bug 1854031. Assigning this bug to you.

Comment 5

[Makoto Kato [:m_kato]]

Attachment: Bug 1854032 - Ship ICU4X segmenter. r=TYLin!,jfkthame!

Comment 6

[Jonathan Kew [:jfkthame]]

Congratulations! \o/

Comment 7

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Please send an "Intent to ship" to dev-platform.

For the record, the previous "Intent to Prototype" is https://groups.google.com/a/mozilla.org/g/dev-platform/c/qzsgy9ueV0Y/m/df-D4qhBAAAJ

Comment 8

[Makoto Kato [:m_kato]]

https://groups.google.com/a/mozilla.org/g/dev-platform/c/ZNluiAQuSGk

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/774474baaad0
Ship ICU4X segmenter. r=TYLin,jfkthame

Comment 10

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/774474baaad0

Comment 11

[Donal Meehan [:dmeehan]]

:m_kato anything you would like to cover in a release note for this? (Process info)

Comment 12

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

+1 to have a release note for ICU4X segmenter. This is an important feature for East Asian and South East Asian end users. One of the improvement is that we now have a proper language-aware word selection when double-click on a text, for languages including Chinese, Japanese, Burmese, Lao, Khmer, and Thai.

Comment 13

[Makoto Kato [:m_kato]]

Release Note Request (optional, but appreciated)
[Why is this notable]: Line and word segment algorithm is compatible with Unicode Standard.
[Affects Firefox for Android]: Yes
[Suggested wording]: The line breaking rules of Web content matches with Unicode Standard. This improves Web browser compatibilities for line breaking.

Also, this is another important feature for East Asian and South East Asian end users. One of the improvement is that we now have a proper language-aware word selection when double-click on a text, for languages including Chinese, Japanese, Burmese, Lao, Khmer, and Thai.
[Links (documentation, blog post, etc)]:

Comment 14

[Donal Meehan [:dmeehan]]

Thanks, added a slightly reworded note to the Fx122 nightly release notes, please allow 30 minutes for the site to update.
Keeping the relnote-firefox flag as ? to keep it on the radar for inclusion in the final Fx122 release notes

Comment 15

[Makoto Kato [:m_kato]]

(In reply to Donal Meehan [:dmeehan] from comment #14)

Thanks, added a slightly reworded note to the Fx122 nightly release notes, please allow 30 minutes for the site to update.
Keeping the relnote-firefox flag as ? to keep it on the radar for inclusion in the final Fx122 release notes

Thanks, I am OK.