1873940 - mozurl_host_port returns the wrong thing for non-spec:/.//

Status: RESOLVED FIXED

(Core :: Networking, defect, P2)

Description

[Valentin Gosu [:valentin] (he/him)]

https://searchfox.org/mozilla-central/rev/52f45d12530f9f8da61c6c7237003b5d1499b6d1/netwerk/base/mozurl/src/lib.rs#217-219

pub extern "C" fn mozurl_host_port(url: &MozURL) -> SpecSlice {
    (&url[Position::BeforeHost..Position::BeforePath]).into()
}

host returns the right thing, but host_port returns a slice. This works for most URLs, but the non-idempotency quirk makes it return /. as a host:port.
This should be fixed, probably by checking if the url has a host before returning.

Comment 1

[Dylan]

Attachment: Bug 1873940 - added port check to mozurl_host_port. r=valentin

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e642cf84fa6f
added port check to mozurl_host_port. r=necko-reviewers,valentin

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/e642cf84fa6f