Closed
Bug 1878636
Opened 1 year ago
Closed 1 year ago
Remove filterPrivateTabs as extensions can't create private tabs in non-private windows anymore
Categories
(Firefox :: Session Restore, task, P3)
Tracking
()
RESOLVED
FIXED
124 Branch
| Tracking | Status | |
|---|---|---|
| firefox124 | --- | fixed |
People
(Reporter: Gijs, Assigned: Gijs)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
The concern for users' privacy in bug 961380 is obviously admirable, but it isn't possible anymore for extensions to create arbitrary private tabs in non-private windows, so now https://searchfox.org/mozilla-central/rev/26dd94a024f21971e539a8650c2f177323c98fe2/toolkit/modules/sessionstore/PrivacyFilter.sys.mjs#121-143 is just a busy-loop that doesn't serve any purpose. Code coverage shows that the inner lines that remove tabs are never executed, which makes sense because the case the loop is worried about (private tabs in non-private windows) can't happen.
We should remove this code.
|
||
Updated•1 year ago
|
Severity: -- → N/A
Type: defect → task
Priority: -- → P3
|
Assignee | |
Comment 1•1 year ago
|
||
|
||
Updated•1 year ago
|
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/519454a6fe47
remove filterPrivateTabs as it creates needless performance churn, r=sfoster,sessionstore-reviewers,kaya,farre
|
||
Comment 3•1 year ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox124:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 124 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•