1892346 - [wpt-sync] Sync PR 45792 - Support :user-valid/:user-invalid on multifield inputs

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 45792 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/45792
Details from upstream follow.

Joey Arhar <[e-mail]> wrote:

Support :user-valid/:user-invalid on multifield inputs

This patch makes :user-valid and :user-invalid start working on inputs
with type date, datetime-local, and time. I matched the webkit behavior
for when to start matching in response to keyboard input.

Fixed: 328674226
Change-Id: If3c394e43043a0b3d27eac22d0671c6b45b82bc6

Reviewed-on: https://chromium-review.googlesource.com/5463293
WPT-Export-Revision: f6e12ad88b52a6f6592ac19427c3509ee33df09c

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=aee62d1b54b22e3037d0056685c5f43dcf2a7f7b

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 4 subtests

Status Summary

Firefox

OK : 3
PASS: 9
FAIL: 5

Chrome

OK : 3
PASS: 9
FAIL: 5

Safari

OK : 3
PASS: 11
FAIL: 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/selectors/user-invalid.html [wpt.fyi]
  • A required date should match :user-invalid if the user unchecks it and blurs.: FAIL (Chrome: FAIL, Safari: PASS)
• /css/selectors/user-valid-user-invalid-multifield-inputs.tentative.html [wpt.fyi]
  • <input type=date> keyboard behavior for :user-valid/:user-invalid.: FAIL (Chrome: FAIL, Safari: FAIL)
  • <input type=time> keyboard behavior for :user-valid/:user-invalid.: FAIL (Chrome: FAIL, Safari: FAIL)
  • <input type=datetime-local> keyboard behavior for :user-valid/:user-invalid.: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/selectors/user-valid.html [wpt.fyi]
  • Date inputs should match :user-valid after the user types a value into it.: FAIL (Chrome: FAIL, Safari: PASS)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3619c39134fb
[wpt PR 45792] - Support :user-valid/:user-invalid on multifield inputs, a=testonly
https://hg.mozilla.org/integration/autoland/rev/1b01036514a2
[wpt PR 45792] - Update wpt metadata, a=testonly

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/3619c39134fb
https://hg.mozilla.org/mozilla-central/rev/1b01036514a2