1931330 - Keyboard shortcut for "Undo close window" fails if no windows are open (and "recently closed windows" submenu hasn't been shown)

Status: RESOLVED FIXED

(Firefox :: Keyboard Navigation, defect)

Description

[Simon Friedberger [:simonf]]

1. Launch Firefox
2. ⌘W (close the only browser window without quitting Firefox)
3. ⇧⌘N (try to reopen the window)

Result: fail beep

This was previously fixed in bug 492320 but now it's broken again.

It seems to have regressed in the range: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=bfd7fe0cf994048e80fb01adc672293b900b6689&tochange=3396ae36832c1e444d7373ab021be20072d57e89

My suspicion is that it was bug 1833522 with https://hg.mozilla.org/mozilla-central/rev/feb42cf3b6e1 so I am setting that as regressor but I haven't verified because that is too far back for mozregression.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1833522

Comment 2

[Simon Friedberger [:simonf]]

Attachment: Bug 1931330 - Special case for PBM detection when no window is open r?dao

Comment 3

[Sam Foster [:sfoster] (he/him)]

Thanks for picking this up. Yeah, the what-kind-of-window check should handle the case that there is no current window (something that currently can only happen on MacOS I believe).

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9842b7d18aa3
Special case for PBM detection when no window is open r=sessionstore-reviewers,sfoster

Comment 5

[amarc]

https://hg.mozilla.org/mozilla-central/rev/9842b7d18aa3

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:simonf, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox133 to wontfix.

For more information, please visit BugBot documentation.

Comment 7

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

I was able to reproduce the issue on an affected Firefox Nightly build from 2024-11-14, using macOS 14.7, as described in Comment 0.
Verified as fixed with Firefox 134.0b2, using macOS 14.7 Using the ⇧⌘N keyboard shortcut reopens the window.