1946645 - Remove HyperTextAccessible::SelectionCount and SelectionBoundsAt

Status: RESOLVED FIXED

(Core :: Disability Access APIs, task)

Description

[James Teh [:Jamie]]

HyperTextAccessibleBase has unified implementations, so there shouldn't be a need to specialise for LocalAccessible. However, accessible/tests/mochitest/textselection/test_general.html fails, so there must be some differences between the implementations. We should either:

1. Determine that this is a bug in the HyperTextAccessibleBase implementation and fix it; or
2. Fix the test.

Comment 1

[James Teh [:Jamie]]

Attachment: Bug 1946645: Remove HyperTextAccessible::SelectionCount and SelectionBoundsAt.

These are implemented in HyperTextAccessibleBase.
Having local and remote use the same implementation makes things simpler, more consistent, easier to test and easier to reason about.
This is also necessary in order to properly test the fix in the next patch.

This breaks the rare edge case of selecting only empty containers for LocalAccessible.
This never worked for RemoteAccessible anyway, which is the majority of content now.
Bug 1973154 has been filed for this.

Comment 2

[James Teh [:Jamie]]

(In reply to James Teh [:Jamie] from comment #0)

1. Determine that this is a bug in the HyperTextAccessibleBase implementation and fix it; or

See bug 1973154. Strictly speaking, it's a bug in the Base implementation, but it's rare and I don't think it should block this, especially given that we need it to test bug 1972539.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d950998711a9
https://hg.mozilla.org/integration/autoland/rev/1373df9920db
Remove HyperTextAccessible::SelectionCount and SelectionBoundsAt. r=morgan

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/1373df9920db