1948914 - Bundle webcompat into Firefox Desktop omni jar

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, task, P2)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

This bugzilla issue is tracking the additional changes needed to bundle webcompat into the Firefox Desktop omni jar (on top of the preparation work done as part of Bug 1938155).

Comment 1

[Andrea Marchesini [:baku]]

Attachment: Bug 1948914 - Bundle webcompat into Firefox Desktop omni jar, r?rpl

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d49d202cfea4
Bundle webcompat into Firefox Desktop omni jar, r=rpl,twisniewski,webcompat-reviewers,firefox-desktop-core-reviewers ,mak

Comment 3

[amarc]

Backed out for causing valgrind bustages

• Backout link
• Push with failures
• Failure Log

Comment 4

[Andrea Marchesini [:baku]]

Hi Mike, this issue is strange. I wonder if you can help. The failure shows a "Conditional jump or move depends on uninitialised value(s) at len_utf8 / encode_utf8_raw / encode_utf8 / push_char" in a rust component. Note that this patch does not touch that part at all. Can it be a false positive?

Comment 5

[Mike Hommey [:glandium]]

It's likely to be a false positive... but why would a different code path be taken? After all, the addon is unchanged.

Comment 6

[Andrea Marchesini [:baku]]

Attachment: Bug 1948914 - Suppress false-positive cond jump,

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f4ce0e58a9ff
Suppress false-positive cond jump, r=glandium
https://hg.mozilla.org/integration/autoland/rev/90b8d015e5ca
Bundle webcompat into Firefox Desktop omni jar, r=rpl,twisniewski,webcompat-reviewers,firefox-desktop-core-reviewers ,mak

Comment 8

[Atila Butkovits]

Backed out for causing bustages complaining about packager.mk.

Backout link: https://hg.mozilla.org/integration/autoland/rev/c3991b6b1d9983a89c05bda8adff7815fc45ec86

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=a2cd0bcc2fe2302e9d5293c6b43e828752e99908

Failure log: https://treeherder.mozilla.org/logviewer?job_id=500315673&repo=autoland&lineNumber=156792

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/daf557f15c21
Suppress false-positive cond jump, r=glandium
https://hg.mozilla.org/integration/autoland/rev/a16bb0b1f7b4
Bundle webcompat into Firefox Desktop omni jar, r=rpl,twisniewski,webcompat-reviewers,firefox-desktop-core-reviewers ,mak

Comment 10

[amarc]

Backed out for causing multiple failures

• Backout link
• Push with failures
• Failure Log -> Mn failures
• Failure Log 1 -> bc failure
• Failure Log 2 -> bc failure

Comment 11

[Andrea Marchesini [:baku]]

Attachment: Bug 1948914 - Remove startup system XPI checks in tests, r?rpl

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/65f1f76986a5
Suppress false-positive cond jump, r=glandium
https://hg.mozilla.org/integration/autoland/rev/51b1d6eef7fb
Bundle webcompat into Firefox Desktop omni jar, r=rpl,twisniewski,webcompat-reviewers,firefox-desktop-core-reviewers ,mak
https://hg.mozilla.org/integration/autoland/rev/bee507127315
Remove startup system XPI checks in tests, r=rpl,mconley

Comment 13

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/65f1f76986a5
https://hg.mozilla.org/mozilla-central/rev/51b1d6eef7fb
https://hg.mozilla.org/mozilla-central/rev/bee507127315

Comment 16

[Mayank Bansal]

Expectedly, increased the installer size browser-omni.ja on windows by 630KB.