202764 - nsXULDocument::HandleDOMEvent can go away

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Brian Ryner (not reading)]

Now that nsXULDocument inherits from nsDocument, it looks like
nsXULDocument::HandleDOMEvent can go away and we can just use the superclass
implementation.  It seems to be functionally the same, just a few extra checks
for local handling (which appear to be more correct).

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Removing nsXULDocument::HandleDOMEvent

So, like this.
The only difference atm is the local handling.
As far as I understand nsDocument does it right.
http://lxr.mozilla.org/seamonkey/source/content/base/src/nsDocument.cpp#4114
http://lxr.mozilla.org/seamonkey/source/content/xul/document/src/nsXULDocument.cpp#1237

Comment 2

[Johnny Stenback (:jst)]

Comment on attachment 194780 [details] [diff] [review]
Removing nsXULDocument::HandleDOMEvent

r=jst

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 194780 [details] [diff] [review]
Removing nsXULDocument::HandleDOMEvent

sr=bzbarsky.  Let me know if you need this checked in, ok?  (I _think_ you have
a cvs account, but I'm not 100% sure... and if you don't, request one!).

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

(In reply to comment #3)
> (From update of attachment 194780 [details] [diff] [review] [edit])
> sr=bzbarsky.  Let me know if you need this checked in, ok?  (I _think_ you have
> a cvs account, but I'm not 100% sure... and if you don't, request one!).
> 

I do have a cvs account. I'll check this in later today. 

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Checked in