229915 - [SELECTORS-DYNAMIC] we don't restyle for + combinator and content tree changes

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Our handling of content tree changes (removeChild, insertChild, appendChild,
replaceChild) doesn't cause the necessary restyling to handle the + combinator
in CSS selectors.

This is spun off of bug 15608 and is related to bug 73586 and bug 98997.  I'll
attach a testcase sometime...

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Bug 73586, bug 98997, and bug 229915 would be fixed by what I described in step
3 of bug 15608 comment 28:

  When adding/removing content, just reresolve style on the parent (to handle
  empty, +, and all the new CSS3 variants).  (Perhaps there are good ways to
  optimize this, but it might just not be that bad.)

Comment 2

[Martijn Wargers (dead)]

Attachment: inserting element div with insertBefore between a and span with style a+span{background-color:green}

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: testcase

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: testcase

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

It's worth testing ~ as well -- some issues are similar, but some are a bit
different.

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

*** Bug 343652 has been marked as a duplicate of this bug. ***

Comment 7

[Jesse Ruderman]

*** Bug 344990 has been marked as a duplicate of this bug. ***

Comment 8

[Porges]

I just ran into this bug. I have:

h1 + p { text-indent: 0 }
p { text-indent: 2em }

The bug is triggered if I remove a paragraph directly following a header, as the following paragraph that gets moved up is stuck with the old indentation.

Is there a simple workaround for this bug?

Comment 9

[Dão Gottwald [:dao]]

Hit upon this in bug 393718 / attachment 295517 [details] [diff] [review].

Comment 10

[Andreas Blixt]

Attachment: Additional testcase

Additional testcase

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix by checkin of bug 401291 to trunk, 2008-02-18 22:17 -0800.

I included tests for this bug (based on attachment 139253 [details]) in that landing.  However, I think more tests are needed, as none of the tests currently in the tree test any cases where :empty and :-moz-only-whitespace differ, and those cases need to be exercised a good bit.