322565 - [trunk] Going Back to Gmail takes infinitely long

Status: RESOLVED WORKSFORME

(Core :: DOM: Navigation, defect)

Description

[Ria Klaassen (not reading all bugmail)]

Steps to reproduce:

- Login into Gmail
- Visit another site like your homepage
- Click on you toolbar Back button

Expectations: should take me back to Gmail.
Reality: it loads endlessly, without login in, and I see "read mail.google.com" in the status bar.

Regression between 1.9a1_2005111513 and 1.9a1_2005111522.

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=PhoenixTinderbox&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2005-11-15+12%3A00%3A00&maxdate=2005-11-15+22%3A00%3A00&cvsroot=%2Fcvsroot

Comment 1

[:Gavin Sharp [email: [e-mail]]]

With a debug build, I get (the usual principal mismatch asserts and):

###!!! ASSERTION: Adding child where we already have a child?  This will likely misbehave: 'Error', file C:/moz-debug/mozilla/docshell/shistory/src/nsSHEntry.cpp, line 528

Seems like the only relevant changes in that range are Boris'.

Comment 2

[Boris Zbarsky [:bzbarsky]]

This looks like it's basically bug 317240 -- cutting out the short-circuit makes this work.

Comment 3

[Ria Klaassen (not reading all bugmail)]

This seems to work fine now.