331989 - Cancelable events like xforms-reset can't be cancelled

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[Steve Speicher]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1) Opera 7.55  [en] (IBM EVV/3.8/EAK01AGF/LE)
Build Identifier: 

This fails test case: 10.1.2.d

Aaron says this is more of an XML Events bug.

Reproducible: Always

Steps to Reproduce:

Comment 1

[Steve Speicher]

Attachment: test case

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Is this trunk only? If it is, then this is a regression from my event dispatching rewrite.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: proposed patch

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 216546 [details] [diff] [review]
proposed patch

yep, seems to fix it. And this is a trunk only bug.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

So the bug is that nsXTFElementWrapper::PostHandleEvent
doesn't check whether preventDefault is called.
The simple check for that is enough.

Comment 6

[Johnny Stenback (:jst)]

Comment on attachment 216546 [details] [diff] [review]
proposed patch

r+sr=jst

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Checking in src/nsXTFElementWrapper.cpp;
/cvsroot/mozilla/content/xtf/src/nsXTFElementWrapper.cpp,v  <--  nsXTFElementWrapper.cpp
new revision: 1.31; previous revision: 1.30
done