342011 - xul window load event handlers no longer called with evt.eventPhase == Event.AT_TARGET

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Bob Clary [:bc] (inactive)]

Beginning with 2006-06-16-04 nightly trunk builds, event handlers in xul windows specified either by this.addEventListener('load', loadHandler, true) or via <xul:window onload="loadHandler()"> are no longer called with evt.eventPhase == Event.AT_TARGET but are only called with evt.eventPhase == Event.CAPTURING_PHASE.

There are several ways to demonstrate the change, this has been the easiest for me:

1. Install spider 
   <http://bclary.com/projects/spider/spider/spider.xpi>

2. From a normal browser window, open venkman, disable exclude browser files and set 
  /fbreak spider.js 41
  /fbreak spider.js 83

3. paste chrome://spider/content/spider.xul into the url bar

4. at the break points, inspect evt.eventPhase

In 1.8.x builds and trunk builds prior to 2006-06-16 you will see
at line 41: CAPTURING_PHASE then AT_TARGET
at line 83: AT_TARGET

in trunk builds on or after 2006-06-16 you will only see CAPTURING_PHASE.

I can probably work around this if this change is intentional, but if it is not I would prefer to get this fixed as it _blocks all test automation on the trunk which uses Spider_.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: proposed patch

this is a regression from Bug 339659.
I forgot that some events which are dispatched to |window| don't actually have
|window| as the originalTarget.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Attachment: testcase

On branches this alerts AT_TARGET, on trunk CAPTURING

Comment 3

[Bob Clary [:bc] (inactive)]

(In reply to comment #1)
> Created an attachment (id=226145) [edit]
> proposed patch

This fixes the problem for me on winxp.

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 226145 [details] [diff] [review]
proposed patch

r/sr=sicking

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 226145 [details] [diff] [review]
proposed patch

But make a note in bug 235441 as well, rather than just leaving it in the code.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Checked in.

Comment 7

[Bob Clary [:bc] (inactive)]

verified fixed on windows trunk opt build. Thanks!