378369 - Crash [@ nsEventListenerManager::FixContextMenuEvent] when firing contextmenu event in display: none iframe

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Martijn Wargers (dead)]

Attachment: testcase

See testcase, which crashes current trunk builds after 300ms, it doesn't crash on branch.
I could look for a regression range, if wanted.

Talkback ID: TB31426666Z
nsEventListenerManager::FixContextMenuEvent  [mozilla/content/events/src/nseventlistenermanager.cpp, line 1408]
nsEventListenerManager::HandleEvent  [mozilla/content/events/src/nseventlistenermanager.cpp, line 1140]
nsEventTargetChainItem::HandleEvent  [mozilla/content/events/src/nseventdispatcher.cpp, line 209]
nsEventTargetChainItem::HandleEventTargetChain  [mozilla/content/events/src/nseventdispatcher.cpp, line 241]
nsEventDispatcher::Dispatch  [mozilla/content/events/src/nseventdispatcher.cpp, line 484]
nsEventDispatcher::DispatchDOMEvent  [mozilla/content/events/src/nseventdispatcher.cpp, line 538]
nsDocument::DispatchEvent  [mozilla/content/base/src/nsdocument.cpp, line 4666]
NS_InvokeByIndex  [mozilla/xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp, line 102]
XPCWrappedNative::CallMethod  [mozilla/js/src/xpconnect/src/xpcwrappednative.cpp, line 2247]

Comment 1

[Steve England [:stevee]]

No Crash
- Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060307 Firefox/1.6a1 ID:2006030704 [cairo]

Crash
- Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060308 Firefox/1.6a1 ID:2006030807 [cairo]

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=PhoenixTinderbox&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-03-07+03&maxdate=2006-03-08+08&cvsroot=%2Fcvsroot

Comment 2

[Steve England [:stevee]]

Due to bug 234455?

Comment 3

[Martijn Wargers (dead)]

(In reply to comment #2)
> Due to bug 234455?

Yeah, probably.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Attachment: null check

Comment 5

[Johnny Stenback (:jst)]

Comment on attachment 262472 [details] [diff] [review]
null check

r+sr=jst

Comment 6

[Martijn Wargers (dead)]

Verified fixed, using:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a4pre) Gecko/20070427 Minefield/3.0a4pre

Comment 7

[Mats Palmgren (inactive)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/70f98493cbcb

Comment 8

[Gregory Szorc [:gps]]

https://hg.mozilla.org/mozilla-central/rev/70f98493cbcb