392797 - Don't fake the results in nsTextAccessible::GetFrame()

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Aaron Leventhal]

The original implementation of nsTextAccessible::GetFrame() was developed when we mostly needed frames to report the current style or bounds of an object.

I want to change GetFrame() so that it only returns the actual frame for an object. It is safer to provide the accurate results. If a frame does not exist for a text object, it means that the accessible object is now DEFUNCT.

I saw a problem with this code when working on bug 391846. We were receiving observing a node change and the text frame for the associated accessible was no longer available. Thus the GetFrame() method was returning the body frame, which is totally inappropriate and incorrect.

Comment 1

[Aaron Leventhal]

Sorry, that was nsAccessNode::GetFrame() that walks up. I think we may have done that for image map areas.

Comment 2

[Aaron Leventhal]

Attachment: Don't use parent chain for nsaccessNode::GetFrame()

Actually I don't see any place where we need that code. The things that don't have their own frame are tree items, image map areas and list item bullets. I have verified that all of those still return the container accessible's frame for GetFrame().

Comment 3

[alexander :surkov (:asurkov)]

Comment on attachment 277337 [details] [diff] [review]
Don't use parent chain for nsaccessNode::GetFrame()

I don't too where it might be used. lxr said this was changed in 1.21 revision, in bug 283482. But I didn't find any word there why it has been done and more patch doesn't contain this change. It's diversion I guess :)

So r=me