398326 - [FIX]"ASSERTION: Should be in an update while creating frames" with xul listbox

Status: RESOLVED FIXED

(Core :: XUL, defect, P1)

Description

[Jesse Ruderman]

Attachment: testcase

Loading the testcase (in Mac trunk debug) triggers:

###!!! ASSERTION: Should be in an update while creating frames: 'mUpdateCount != 0', file /Users/jruderman/trunk/mozilla/layout/base/nsCSSFrameConstructor.cpp, line 6682

This assertion was added in bug 398108.

Comment 1

[Boris Zbarsky [:bzbarsky]]

See, that's the think.  I tried testing listboxes before landing bug 398108 because I expected them to assert...  but they didn't.  Neither does that testcase, in my build.

What's the stack you see to the assert?

Comment 2

[Jesse Ruderman]

Attachment: stack trace for the assertion

Stack trace for the first instance of the assertion.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix

I still don't know why I couldn't reproduce....

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 283293 [details] [diff] [review]
Fix

r+sr=dbaron, although we should probably invest in guard objects for this at some point...

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 283293 [details] [diff] [review]
Fix

a1.9=dbaron

Comment 6

[Boris Zbarsky [:bzbarsky]]

Checked in.  Could use a test in layout/crashtests or whatever bug 397725 decides on.

Comment 7

[Jesse Ruderman]

Crashtest checked in.