402089 - nsDOMUIEvent should cache coordinates when DuplicatePrivateData is called

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

This is sort of regression from 1.8.0, though in that branch coordinates from
already dispatched events works only in some cases and apparently occasionally
trying to get the coordinates causes crashes.
But anyway to work more like Opera and Safari, the coordinates should be cached.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: testcase

This testcase passes on Opera and Safari.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Attachment: proposed patch

Not sure if this should block 1.9. Probably not, but at least should be wanted-1.9.
Adding more members to nsDOMUIEvent shouldn't be bad, since we usually have only
very few events alive in the same time.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: proposed patch

Oops, the testcase didn't quite work in the previous patch.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Making events to work more consistently with other browsers is IMO definitely
wanted-1.9, so asking approval-

Comment 5

[[e-mail]]

This seems to trigger an assertion when you hit Esc to close Print Preview.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

um, right, that sort of useless assertion.
nsPresContext::PresShell() should be removed, and only nsPresContext::GetPresShell() should be used.

Comment 7

[Bill Gianopoulos [:WG9s]]

This check-in completely breaks the maps.live.com site.

See bug 405632 for details.

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

(In reply to comment #7)
> This check-in completely breaks the maps.live.com site.

Why "completely" ?