404281 - [FIX]layout can pass widgets a layout width of "1<<30"

Status: RESOLVED FIXED

(Core :: Layout, defect, P4)

Description

[Josh Aas]

In bug 398336 we discovered that layout can pass widgets a layout width of "1<<30". This almost certainly shouldn't be happening.

"Loading the testcase from Bug 398158 (https://bugzilla.mozilla.org/attachment.cgi?id=283018)(and clicking on this bar) freeze Trunk Builds and the entire mac system."

I've heard that the freeze will only happen the first time the  bad code runs on a boot, so if you reproduce it once you'll have to reboot to get it again. Presumably the layout bug still happens but Mac OS X just doesn't freeze up more than once.

Comment 1

[Josh Aas]

As noted in the other bug, this is a regression from Eli's Gecko units patch.

"I've traced it to the Gecko units patch in bug 177805, landed back in February; previous code works, apply patch, rebuild, now it fails." - Stan Shebs

Comment 2

[Boris Zbarsky [:bzbarsky]]

I can't load the bug in comment 0....

This is likely the same as bug 363858, if https://bugzilla.mozilla.org/attachment.cgi?id=283018 is the right testcase.

Comment 3

[Josh Aas]

Sorry, bug 398157.

Attachment:
https://bugzilla.mozilla.org/attachment.cgi?id=283018

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

We probably should have some bulletproofing in widget code to protect against creating super-large widgets.

Comment 5

[Josh Aas]

See bug 398336 comment #15, that bug is about bulletproofing in widget code now.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Patch in bug 363858 will fix this.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Fixed by checkin for bug 363858.