406729 - vertical scroll wheeling over the url bar nudges contents 1-2 px

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[(not reading, please use [e-mail] instead)]

two finger can vertically scrolling scrolls the url bar

note, this not bug #406373

steps to reproduce:

1) load a url
2) click in the url bar
3) use two fingers on your mac and attept to scroll vertically

the url will move up and down about 1 or two pixels!

Comment 1

[Ed Lee :Mardak]

Regressed between 2007120204 and 2007120304. I noticed it didn't happen with my adaptive build from 12/01 which had the 2-line results.

Note, you just need to mouse over and scroll. No need to click.

Comment 2

[(not reading, please use [e-mail] instead)]

Edward, last night over irc you mentioned that you might have figured out which change regressed this?  unfortunately, I quit irc and lost your comment.

Comment 3

[Ed Lee :Mardak]

Oh, nope. I didn't find the actual checkin that regressed - only the range. But there weren't any autocomplete checkins.

http://bonsai.mozilla.org/cvsquery.cgi?date=explicit&mindate=2007-12-02+04&maxdate=2007-12-03+04

Probably isn't the listbox one - that's just a NS_NOTREACHED removal.

Comment 4

[Reed Loden [:reed]]

Mardak, want to try the hourlies at http://hourly-archive.localgho.st/ and track down the regression range?

Comment 5

[Ed Lee :Mardak]

Thanks.

http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1196663940&maxdate=1196665859

Bug 392785 overflowed underline sometimes is not repainted at scrolling r+sr=roc, b1.9=dbaron 
Don't do arithmetic with unconstrained widths when reflowing comboboxes. Bug
363858, r+sr=dbaron 

bz says not the latter, so bug 392785 it is.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Probably what happened is that we're adding overflow area to the urlbar text which makes it scrollable vertically.

We should be able to fix things so that single-line text controls never scroll vertical even if they have overflow there. I wonder if that's enough. We should back out bug 392785 for beta2 though, I think.

Comment 7

[Martijn Wargers (dead)]

The patch for bug 392785 was backed out, so this should be fixed. Please test in tomorrow's build.

Comment 8

[Ed Lee :Mardak]

Verified fixed with steps.

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O 10.4; en-US; rv:1.9b2pre) Gecko/2007120415 Minefield/3.0b2pre

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sick)]

(In reply to comment #6)
> Probably what happened is that we're adding overflow area to the urlbar text
> which makes it scrollable vertically.
> 
> We should be able to fix things so that single-line text controls never scroll
> vertical even if they have overflow there. I wonder if that's enough. We should
> back out bug 392785 for beta2 though, I think.

I think that the real cause is bug 402524 and bug 396809. I have posted the patch for them, but it's not reviewed :-(