Closed
Bug 452912
Opened 17 years ago
Closed 16 years ago
Optimize Windows x64 build for javascript engine
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: m_kato, Assigned: m_kato)
References
Details
Attachments
(1 file, 1 obsolete file)
2.77 KB,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
jsbit and jslock has no optimization for x64 Windows.
- MSVC for x64 has no inline assembler. But x64 has _InterlockedCompareExchange64 for exchange compare.
- MSVC for x64 is version 14 or later.
Assignee | ||
Updated•17 years ago
|
Attachment #336164 -
Flags: superreview?(brendan)
Attachment #336164 -
Flags: review?(brendan)
Updated•17 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 1•17 years ago
|
||
Comment on attachment 336164 [details] [diff] [review]
patch v1 for Win64 x64
We don't use SR in js/src.
David, can you look? Or punt to crowder if he is game -- he's Windows enabled, if not Windows 64-bit enabled (who has such a system at Mozilla, anyway?).
/be
Attachment #336164 -
Flags: superreview?(brendan)
Attachment #336164 -
Flags: review?(danderson)
Attachment #336164 -
Flags: review?(brendan)
Assignee | ||
Updated•17 years ago
|
OS: Windows Vista → Windows XP
Hardware: x86 → x86_64
Assignee | ||
Updated•17 years ago
|
Blocks: tracking_win64
Assignee | ||
Comment 2•16 years ago
|
||
sync with latest tree
Attachment #336164 -
Attachment is obsolete: true
Attachment #390619 -
Flags: review?
Attachment #336164 -
Flags: review?(dvander)
Assignee | ||
Updated•16 years ago
|
Attachment #390619 -
Flags: review? → review?(dvander)
![]() |
||
Updated•16 years ago
|
Attachment #390619 -
Flags: review?(dvander) → review+
Assignee | ||
Comment 3•16 years ago
|
||
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•