Closed Bug 456672 Opened 17 years ago Closed 17 years ago

Port |Bug 438927 - ###!!! ASSERTION: XPConnect is being called on a scope without a 'Components' property!| to SeaMonkey

Categories

(SeaMonkey :: MailNews: General, defect)

Product:
SeaMonkey
Component:
MailNews: General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.0a2

People

(Reporter: sgautherie, Assigned: sgautherie)

References

(Blocks 2 open bugs,
URL
)

Details

(Keywords: assertion)

Attachments

(2 files, 2 obsolete files)

(Bv1) Port bug 438927 [Checkin: Comment 13]
5.46 KB, patch
iannbugzilla
: review+
neil
: superreview+
kairo
: approval-seamonkey2.0a1-
Details | Diff | Splinter Review
(Cv1) <SearchDialog.js> [Checkin: See comment 16]
2.05 KB, patch
mnyromyr
: review+
neil
: superreview+
Details | Diff | Splinter Review
No description provided.
Blocks: TB2SM
Attached patch (Av1) <history.js> (obsolete) — — Splinter Review
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b1pre) Gecko/20080921023908 SeaMonkey/2.0a1pre] (home, debug default) (W2Ksp4) This is the only case to fix in /suite: http://mxr.mozilla.org/comm-central/search?string=%28ert%7Cend%7Cove%29Controller&regexp=on&case=on
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #340102 - Flags: review?(db48x)
Depends on: 456694
Depends on: 456696
Blocks: 415775
Comment on attachment 340102 [details] [diff] [review] (Av1) <history.js> r=db48x
Attachment #340102 - Flags: review?(db48x) → review+
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b1pre) Gecko/20080921023908 SeaMonkey/2.0a1pre] (home, debug default) (W2Ksp4) I added |widget.controllers.removeController(FolderPaneController);|: I didn't check if this one is specifically needed, but it shouldn't hurt !? *** I'll look into the other /mailnews occurrences later...
Attachment #340110 - Flags: superreview?(neil)
Attachment #340110 - Flags: review?(iann_bugzilla)
Comment on attachment 340102 [details] [diff] [review] (Av1) <history.js> "approval-seamonkey2.0a1=?": I didn't check if this one caused an assertion, but it is cleaner and no risk.
Attachment #340102 - Flags: approval-seamonkey2.0a1?
Attachment #340102 - Flags: superreview-
Attachment #340102 - Flags: approval-seamonkey2.0a1?
Attachment #340102 - Flags: approval-seamonkey2.0a1-
Comment on attachment 340102 [details] [diff] [review] (Av1) <history.js> Bug 438927 only affects window objects, not XUL elements.
(In reply to comment #5) > (From update of attachment 340102 [details] [diff] [review]) > Bug 438927 only affects window objects, not XUL elements. Sorry I mean bug 415775 of course.
Comment on attachment 340110 [details] [diff] [review] (Bv1) Port bug 438927 [Checkin: Comment 13] I guess this is OK as you're removing the window controller anyway.
Attachment #340110 - Flags: superreview?(neil) → superreview+
Attachment #340110 - Flags: review?(iann_bugzilla) → review+
Comment on attachment 340110 [details] [diff] [review] (Bv1) Port bug 438927 [Checkin: Comment 13] "approval-seamonkey2.0a1=?": Fix 3 assertion cases; no risk.
Attachment #340110 - Flags: approval-seamonkey2.0a1?
Attached patch (Av2) <history.js> (obsolete) — — Splinter Review
Av1, with comment 5 suggestion(s).
Attachment #340102 - Attachment is obsolete: true
Attachment #340143 - Flags: superreview?(neil)
Attachment #340143 - Flags: review?(db48x)
Blocks: 456694
No longer depends on: 456694
Blocks: 456696
No longer depends on: 456696
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b1pre) Gecko/20080921023908 SeaMonkey/2.0a1pre] (home, debug default) (W2Ksp4) *Fix the (only) one assertion caused by this "window". *(unrelated) Untabify this file.
Attachment #340150 - Flags: superreview?(neil)
Attachment #340150 - Flags: review?(mnyromyr)
Comment on attachment 340110 [details] [diff] [review] (Bv1) Port bug 438927 [Checkin: Comment 13] Following in-Council IRC discussion, this can wait for a2.
Attachment #340110 - Flags: approval-seamonkey2.0a1? → approval-seamonkey2.0a1-
Blocks: 456860
(In reply to comment #3) > I'll look into the other /mailnews occurrences later... I filed bug 456696 and bug 456860.
Component: MailNews: Message Display → MailNews: General
QA Contact: message-display → mail
Target Milestone: seamonkey2.0alpha → seamonkey2.0beta
Comment on attachment 340110 [details] [diff] [review] (Bv1) Port bug 438927 [Checkin: Comment 13] http://hg.mozilla.org/comm-central/rev/223f113ae510
Attachment #340110 - Attachment description: (Bv1) Port bug 438927 → (Bv1) Port bug 438927 [Checkin: Comment 13]
Blocks: 442482
Attachment #340150 - Flags: superreview?(neil) → superreview+
Comment on attachment 340143 [details] [diff] [review] (Av2) <history.js> As yet we don't even know whether we'll keep any of this code when we switch to places, so I don't see the point of patching it... perhaps your time would be better spent making the history manager work with places ;-)
Comment on attachment 340150 [details] [diff] [review] (Cv1) <SearchDialog.js> [Checkin: See comment 16] r=me for the actual fix line only, but please leave the other lines alone, since you're not doing substantial changes there.
Attachment #340150 - Flags: review?(mnyromyr) → review+
Attachment #340150 - Attachment description: (Cv1) <SearchDialog.js> → (Cv1) <SearchDialog.js> [Checkin: See comment 16]
Comment on attachment 340150 [details] [diff] [review] (Cv1) <SearchDialog.js> [Checkin: See comment 16] Cv1, with comment 15 suggestion(s): http://hg.mozilla.org/comm-central/rev/7fe8dc6fc848
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: seamonkey2.0beta → seamonkey2.0a2
No longer blocks: 442482
No longer depends on: 438927
Attachment #340143 - Attachment is obsolete: true
Attachment #340143 - Flags: superreview?(neil)
Attachment #340143 - Flags: review?(db48x)
Comment on attachment 340143 [details] [diff] [review] (Av2) <history.js> Obsoleted by bug 382187.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: