459257 - MozillaBuild fails on WinXP x64 due to errors in guess-msvc/start-* scripts

Status: RESOLVED FIXED

(Firefox Build System :: MozillaBuild, task)

Description

[Nils Maier [:nmaier]]

Attachment: patch v1, fix guess/start scripts

The guess-msvc script incorrectly assumes the installation directory information is always held under a specific RegKey and therefore fails on x64 where is is actually held under the WOW6432Key.

Furthermore the start-msvc* scripts break because of paths that contain brackets (those (x86) abstraction paths).

And finally one has to execute bash from a x86 shell or else if will complain bitterly that it is unable to fork().


guess patch part taken from bug 449068

Tested on against WinXP 64 Pro SP2 and WinXP 32 Pro SP3 (to ensure stuff doesn't break 32bit Windows).

After applying attached patch ([1]) and installing the newer msys dll[2] (following advice from [3]) I was able to successfully build trunk and mozilla-central on my WinXP x64 box.

[1] patch -p3 if applied to an installation directly
[2] http://downloads.sourceforge.net/mingw/MSYS-1.0.11-20080821-dll.tar.gz
[3] http://www.mozilla-x86-64.com/archives/2007/12/mozilla_build_s.html

Comment 1

[(not currently active) Ted Mielczarek]

Why did you file a new bug on this when we already had one?

Comment 2

[J. Paul Reed [:preed]]

Comment on attachment 342451 [details] [diff] [review]
patch v1, fix guess/start scripts

And if anything, this r? shouldn't be me; it should be ted or bhearsum.

Canceling.

Comment 3

[Nils Maier [:nmaier]]

(In reply to comment #1)
> Why did you file a new bug on this when we already had one?

Because I don't think the other bug is exactly the same.
This patch addresses XP issues, not necessarily Vista issues. It just happens that part of the Vista issues might be fixed by the patch as well (didn't check as I don't have a Vista x64 around currently).

I thought a clean separation of bugs would be the better thing to do. If you think otherwise feel free to correct.

Comment 4

[(not currently active) Ted Mielczarek]

It's clearly the same issue, it has to do with the paths and registry paths under x64, not at all to do with XP vs. Vista.

Comment 5

[Masahiro YAMADA]

(In reply to attachment 342451 [details] [diff] [review])

> if exist "%WINDIR%\SYSWOW64\CMD.EXE" (
>   %WINDIR%\\SYSWOW64\CMD.EXE /c %MOZILLABUILD%\msys\bin\bash --login -i
> ) else (
>   %MOZILLABUILD%\msys\bin\bash --login -i
> )

I think it would better to quote path of bash like following (bug 458897).

if exist "%WINDIR%\SYSWOW64\CMD.EXE" (
 %WINDIR%\\SYSWOW64\CMD.EXE /c "%MOZILLABUILD%\msys\bin\bash" --login -i
) else (
 "%MOZILLABUILD%\msys\bin\bash" --login -i
)

# If installer of Windows-64bit can change name of WINDIR
# (as like installer of NT4.0 can.),
# it may be needed to quote "%WINDIR%\\SYSWOW64\CMD.EXE" too.

Comment 7

[Ronny Perinke]

(In reply to comment #1)
> that part of the Vista issues might be fixed by the patch as well (didn't check
> as I don't have a Vista x64 around currently).

I can confirm the registry keys on Vista x64.

Comment 8

[(not currently active) Ted Mielczarek]

Comment on attachment 342451 [details] [diff] [review]
patch v1, fix guess/start scripts

I'm intentionally not reviewing this currently because I don't have time to work on MozillaBuild. When I get time, I promise to review this.

Comment 10

[(not currently active) Ted Mielczarek]

Comment on attachment 342451 [details] [diff] [review]
patch v1, fix guess/start scripts

Looks good, I'll push this for you.

Comment 11

[(not currently active) Ted Mielczarek]

Pushed:
http://hg.mozilla.org/mozilla-build/rev/7b301b3453d6

I'll be releasing a MozillaBuild 1.4 soon that will include this change.