486549 - "ASSERTION: nsMediaStream::Close called on non-main thread" with LoadOggHeaders on the stack, still

Status: RESOLVED WORKSFORME

(Core :: Audio/Video, defect)

Description

[Jesse Ruderman]

###!!! ASSERTION: Only call on main thread: 'NS_IsMainThread()', file /Users/jruderman/central/content/media/video/src/nsMediaStream.cpp, line 181

nsMediaChannelStream::Close()
nsChannelReader::destroy()
oggplay_channel_reader_destroy(_OggPlayReader*)
oggplay_close
oggplay_open_with_reader
nsOggDecodeStateMachine::LoadOggHeaders(nsChannelReader*)
nsOggDecodeStateMachine::Run()
nsThread::ProcessNextEvent(int, int*)
NS_ProcessNextEvent_P(nsIThread*, int)
nsThread::ThreadFunc(void*)
_pt_root
_pthread_start
thread_start

(Same stack as bug 483324, which is supposedly fixed.)

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Hmm. On trunk, nsChannelReader::destroy is

OggPlayErrorCode nsChannelReader::destroy()
{
  // We don't have to do anything here, the decoder will clean stuff up
  return E_OGGPLAY_OK;
}

So I don't know how we get to nsMdiaChannelStream::Close in your stack...

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

That's true on trunk since April 1 (revision 35879b7a23f9). Jesse, what revision were you testing when you filed this bug?

Comment 3

[Jesse Ruderman]

Probably something from April 1.  I'll just mark this as WFM and take this assertion off of my known-assertions list so I'll notice if it happens again.