Closed
Bug 492736
Opened 16 years ago
Closed 16 years ago
robust nsXULTreeAccessible::GetLastChild
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
VERIFIED
FIXED
People
(Reporter: surkov, Assigned: surkov)
References
(Blocks 1 open bug)
Details
(Keywords: access)
Attachments
(1 file)
|
1.59 KB,
patch
|
MarcoZ
:
review+
davidb
:
review+
|
Details | Diff | Splinter Review |
In the meantime we get treeAcc.firstChild return an accessible (treecols accessible) but treeAcc.lastChild return null in example:
<tree>
<treecols>
<treecol type="primary" type="checkbox">
</treecols>
<treechildren>
blabla treeitems
</treechildren>
</tree>
in this case there is no key column (because column type is checkbox and it's unique) so we can't find treeitems accessibles on windows.
I don't want to add mochitests for this because one time we need to change logic of key column usage and this mochitests won't be valid. I can't think of another testcases.
Attachment #377145 -
Flags: review?(marco.zehe)
Attachment #377145 -
Flags: review?(david.bolter)
|
||
Comment 1•16 years ago
|
||
Comment on attachment 377145 [details] [diff] [review]
patch
Yep looks better. :)
Attachment #377145 -
Flags: review?(marco.zehe) → review+
|
Assignee | |
Comment 2•16 years ago
|
||
David, ping :)
|
||
Comment 3•16 years ago
|
||
Comment on attachment 377145 [details] [diff] [review]
patch
great. r=me
Attachment #377145 -
Flags: review?(david.bolter) → review+
|
|
Assignee | |
Comment 4•16 years ago
|
||
checked in on 1.9.2 - http://hg.mozilla.org/mozilla-central/rev/a4c050e10c51
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
|
||
Comment 5•16 years ago
|
||
Verified in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090517 Minefield/3.6a1pre (.NET CLR 3.5.30729)
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•