500747 - need hint for short cut key in quick search input field - emptytext of "<selection> (ctrl-k)"

Status: RESOLVED FIXED

(Thunderbird :: Search, defect)

Description

[Wayne Mery (:wsmwk)]

need hint for short cut key in quick search input field - emptytext of "<selection> (ctrl-k)". Or the prevailing OS's short cut, eg Command-Option-F on Mac

this is in followup to bug 259587

Comment 1

[Wayne Mery (:wsmwk)]

note - this would help people (probably many) who don't know a short cut exists

Comment 2

[Bryan Clark (DevTools PM) [:clarkbw]]

this would be good for both the gloda search and quick search inputs

Comment 3

[Thomas D. (:thomas8)]

(In reply to comment #2)
> this would be good for both the gloda search and quick search inputs

Bryan, perhaps then you'd want to set the "wanted-thunderbird3+" flag?

Comment 4

[Phil Ringnalda (:philor)]

Here, let me set it. Fixing this would take a string, and 3.0 has been string frozen for quite a while now.

Comment 5

[Thomas D. (:thomas8)]

Hold on, you're sure that this takes a string?

We shouldn't hard-code the shortcut into the emptytext, but it should be generated in the code by merging existing emptytext + live keyboard shortcut, where keyboard shortcut should be derived from whereever it's defined.

Besides, I understand from https://wiki.mozilla.org/Thunderbird:Thunderbird3.1 that the new string freeze deadline for 3.1 is 2010-02-09?

Comment 6

[Phil Ringnalda (:philor)]

Are you going to show me "Search all messages (Cmd+K)" or "Search all messages (⌘K)"? In either case, where are you going to get the Cmd/⌘ string, or the Ctrl for non-Mac? That's either a new string, or reusing a string intended for use elsewhere, which is more l10n impact than a new string, not less. Are you going to hard-code the space between the emptytext and the parenthesis, even if that's not appropriate in all languages? Are you going to use hard-coded parentheses, even though they're not appropriate in all languages?

Or were you just confused about whether wanted-thunderbird3 applies to 3.1? It does not, nor did having a wanted flag do us any particular good, nor do we currently have a wanted-thunderbird3.1 flag.

What this bug is really lacking, more than anything else, is a link to the equivalent Firefox bug, where they (will, perhaps, someday) have solved all the l10n problems of sticking an accesskey into emptytext.

Comment 7

[Ludovic Hirlimann [:Usul]]

(In reply to comment #0)
> need hint for short cut key in quick search input field - emptytext of
> "<selection> (ctrl-k)". Or the prevailing OS's short cut, eg Command-Option-F
> on Mac

can you post STR's ? I see hints on what I need to type to access quicksearch and gloda search. So I'm kind of confused about this bug.

Comment 8

[Jim Porter (:squib)]

This should be fixed; I see "Search all messages... <Ctrl+K>" in the gloda box and "Filter these messages... <Ctrl+Shift+K>" in the quick filter box.