Closed
Bug 525740
Opened 16 years ago
Closed 16 years ago
Bad reordering with floating first-letter and bidi
Categories
(Core :: Layout: Text and Fonts, defect)
Core
Layout: Text and Fonts
Tracking
()
RESOLVED
FIXED
People
(Reporter: smontagu, Assigned: smontagu)
References
Details
Attachments
(2 files)
|
281 bytes,
text/html
|
Details | |
|
2.01 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
This is tnikkel's catch, and the testcase is based on one by him.
|
Assignee | |
Comment 1•16 years ago
|
||
Attachment #409597 -
Flags: review?(roc)
|
|
Assignee | |
Comment 2•16 years ago
|
||
On second thoughts, I wonder if it would be more efficient to set the embeddingLevel property on the inlines during bidi resolution and not do this drilling down at all during reordering. Is there any reason that the property should only be set on text frames?
|
|
Assignee | |
Comment 3•16 years ago
|
||
I asked Uri's opinion about that, and he pointed out that it could cause a lot of bloat, since there could be many more inlines than textframes. Roc, what do you think?
Comment on attachment 409597 [details] [diff] [review]
Patch
Just call nsPlaceholderFrame::GetRealFrameFor.
Attachment #409597 -
Flags: review?(roc) → review+
I think we should probably stick with the current approach for now.
|
|
Assignee | |
Comment 6•16 years ago
|
||
Status: NEW → RESOLVED
Closed: 16 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•