554458 - [typedarray] implement calling valueOf on object assignment

Status: RESOLVED DUPLICATE of bug 985733

(Core :: JavaScript Engine, defect)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

See https://bugzilla.mozilla.org/show_bug.cgi?id=550351#c33 -- when an object is assigned to a typed array element, currently that just ends up as NaN/0.  Instead of we should call valueOf.

Comment 1

[Andreas Gal :gal]

Bleh.

Comment 2

[Andreas Gal :gal]

Alright, so the way to do this is to run an imacro at recording time, that does the value conversion. It will terminate with pc still on the same SETELEM, but now with a primitive type. Look at the various binary ops (i.e. JSOP_ADD). They do just that.

Comment 3

[David Mandelin [:dmandelin]]

Does this still need to be fixed?

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

I think it would be a 'nice to have', but I definitely don't have a high need for it, and I don't think webgl content will either.  Technically, not having this would be a deviation from the combination of various specs (typed arrays, webidl, ES) due to how they define conversion rules, but I don't think it's crucial.

Comment 5

[David Mandelin [:dmandelin]]

Sounds like it doesn't block then.