Closed
Bug 565534
Opened 15 years ago
Closed 5 years ago
Select JSOP_POP not JSOP_POPV for non-tail expression statements
Categories
(Core :: JavaScript Engine, enhancement, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
INACTIVE
People
(Reporter: brendan, Assigned: brendan)
References
Details
Attachments
(1 file)
|
2.93 KB,
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
Seems easy enough. Perf results in a few.
/be
Attachment #445019 -
Flags: review?(mrbkap)
|
Assignee | |
Comment 1•15 years ago
|
||
Perf change is noise.
/be
|
||
Comment 2•15 years ago
|
||
So, I seem to recall the tail call proposal in harmony having a complex definition of what consists of "tail position", and that it involved determining whether you're in a catch block, etc. Do we not have to do that here?
|
|
Assignee | |
Comment 3•15 years ago
|
||
(In reply to comment #2)
> So, I seem to recall the tail call proposal in harmony having a complex
> definition of what consists of "tail position", and that it involved
> determining whether you're in a catch block, etc. Do we not have to do that
> here?
Done in patch for bug 565374, which blocks this and on which bug's patch this bug's patch is based (notice use of pn_tailpos, which is not in tm tip yet!). See the URL for bug 565374 which links to the ES4-era spec.
/be
|
|
||
Updated•15 years ago
|
Attachment #445019 -
Flags: review?(mrbkap) → review+
|
|
Assignee | |
Updated•15 years ago
|
Target Milestone: mozilla1.9.3a5 → ---
|
||
Comment 4•11 years ago
|
||
Blake: is Brendan's r+'d patch (from 2010) still relevant?
Flags: needinfo?(mrbkap)
|
|
||
Comment 5•11 years ago
|
||
Not really. The code has changed dramatically since this patch was written (and we'd have to land bug 565374 first anyway).
Flags: needinfo?(mrbkap)
|
||
Comment 6•5 years ago
|
||
Let's just close this.
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → INACTIVE
You need to log in
before you can comment on or make changes to this bug.
Description
•