Closed
Bug 589026
Opened 15 years ago
Closed 15 years ago
test_bug535043.html is taking too much time for nothing
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
People
(Reporter: mounir, Assigned: mounir)
References
Details
Attachments
(1 file, 1 obsolete file)
|
2.83 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
This test is simulating key press on textarea which takes a lot of times and it is simulating more than 250 key presses like 10 times... On my computer, I need 90 seconds for a test that is completely trivial.
|
Assignee | |
Comment 1•15 years ago
|
||
This is reducing the number of synthesizeKey calls and it is also doing some cleaning in the test.
Now, the test is run in one second.
Attachment #467632 -
Flags: review?(ehsan)
|
||
Comment 2•15 years ago
|
||
Comment on attachment 467632 [details] [diff] [review]
Patch v1
You should let the test use waitForFocus. In general, tests which synthesize keystrokes will fail intermittently on Linux unless the keystroke synthesis is done inside a waitForFocus callback.
The rest of the patch looks great!
Attachment #467632 -
Flags: review?(ehsan) → review-
|
|
Assignee | |
Comment 3•15 years ago
|
||
Attachment #467632 -
Attachment is obsolete: true
Attachment #467933 -
Flags: review?(ehsan)
|
|
||
Updated•15 years ago
|
Attachment #467933 -
Flags: review?(ehsan) → review+
|
|
Assignee | |
Comment 4•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•