595507 - When an invalid form in an IFRAME is submitted, error messages are not displayed

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[gadjo]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b6pre) Gecko/20100911 Firefox/4.0b6pre
Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b6pre) Gecko/20100911 Firefox/4.0b6pre

When the page contains an IFRAME with the form containing required fields the error message "This field is required" is not displayed

Reproducible: Always

Steps to Reproduce:
1. Open the page http://files.karczmarczyk.pl/x/
2. Don't fill in the text input, just click "Submit"

Actual Results:  
Nothing happens

Expected Results:  
Error message "This field is required" should be displayed

When you open the iframe page http://files.karczmarczyk.pl/x/iframe.html the error message is displayed

Comment 1

[Mounir Lamouri (:mounir)]

Nice catch ;)

I will investigate that. I think this should probably be a blocker considering this will give a very bad experience to our users.

Comment 2

[Johnathan Nightingale [:johnath]]

Oops - didn't mean to reset assignee.

Comment 3

[Mounir Lamouri (:mounir)]

I do not think that's a dom bug actually. The message is shown by browser.js.

Comment 4

[Johnny Stenback (:jst)]

Blocking based on comment 1.

Comment 5

[Mounir Lamouri (:mounir)]

Attachment: Patch v1

Comment 6

[Mounir Lamouri (:mounir)]

Attachment: Patch v1.1

Oups, qnew put some other changes inside the patch. Should be better now.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 475988 [details] [diff] [review]
Patch v1.1

r=me if you also change "gBrowser.selectedTab.linkedBrowser.contentDocument" to "gBrowser.contentDocument" :)

Comment 8

[Mounir Lamouri (:mounir)]

Pushed:
http://hg.mozilla.org/mozilla-central/rev/2a2ec6c26acf