602531 - Change "-moz-box-shadow" to "box-shadow" in mail/

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Nomis101]

-moz-box-shadow is obsolete in Gecko 2.0, so we should rename it to box-shadow. This was done for suite in Bug 595630.

Comment 1

[Nomis101]

Attachment: patch

This patch changes -moz-box-shadow to box-shadow in mail/.
https://developer.mozilla.org/en/CSS/-moz-box-shadow
And it changes the values according to this table: https://bugzilla.mozilla.org/show_bug.cgi?id=590039#c23
It also changes "0px" to "0" in messageHeader.css like it was done in http://hg.mozilla.org/mozilla-central/rev/4e12a34e5398

Comment 2

[Stefan [:stefanh]]

Note that the blur radius value is the third one. You don't want to change the other ones.

Comment 3

[Nomis101]

Attachment: corrected patch

Oh yes, I've overlooked that the value change is only necessary for the blur radius.

Comment 4

[Nomis101]

Attachment: corrected patch

Comment 5

[Andreas Nilsson (:andreasn)]

All values looks good when comparing with the table in https://bugzilla.mozilla.org/show_bug.cgi?id=590039#c23, just going to take it for a test run and see that things looks correct before I give an r+

Comment 6

[Andreas Nilsson (:andreasn)]

Comment on attachment 481619 [details] [diff] [review]
corrected patch

Look all right in action too!

Comment 7

[Ludovic Hirlimann [:Usul]]

So checking needed ?

Comment 8

[Nomis101]

(In reply to comment #7)
> So checking needed ?

Yep.

Comment 9

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/3206b1b12264