604386 - Prune placeholder from text children

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect, P1)

Description

[David Bolter [:davidb] (NeedInfo me for attention)]

The placeholder gets in the way of our nice accessibility traversal and related expectations. This has led to disabling of tests and impedes bug 570275.

Comment 1

[David Bolter [:davidb] (NeedInfo me for attention)]

As per Alexander, need to look at nsIContent::GetChildren for HTML inputs...

Comment 2

[alexander :surkov (:asurkov)]

(In reply to comment #1)
> As per Alexander, need to look at nsIContent::GetChildren for HTML inputs...

small correction, I think you need to override nsIContent::GetChildren for HTML inputs

Comment 3

[alexander :surkov (:asurkov)]

David, if you'll get a wip then please file it here, I might continue it.

Comment 4

[David Bolter [:davidb] (NeedInfo me for attention)]

Right nsHTMLInputElement. I'll set you as owner for this bug, at least until I have a working DOMi.

Comment 5

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 483450 [details] [diff] [review]
patch

The nsIContent API needs to take PRUint32 as well now, no?

The nsIAnonymousContentCreator change needs to document what set of values can be passed for the filter.

I'd prefer reversing the sense of the check in nsTextControlFrame and just moving 

   aElements.MaybeAppendElement(txtCtrl->GetPlaceholderNode());

into the if body with the reversed check.

sr=me with those changes.

Comment 7

[alexander :surkov (:asurkov)]

Attachment: patch2

bz's comments are addressed

Comment 8

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 483450 [details] [diff] [review]
patch

r=me. (Assuming you can address bz's comments)
It wasn't the solution I was thinking of, but it does leave the door open to adding more filters I guess?

Comment 9

[alexander :surkov (:asurkov)]

(In reply to comment #8)
> It wasn't the solution I was thinking of, but it does leave the door open to
> adding more filters I guess?

sure, it's flexible approach.

Comment 10

[alexander :surkov (:asurkov)]

Boris, are you ok with patch2, any other suggestions?

Comment 11

[David Bolter [:davidb] (NeedInfo me for attention)]

The only thing missing is the nsIAnonymousContentCreator documentation about filters.

Comment 12

[alexander :surkov (:asurkov)]

(In reply to comment #11)
> The only thing missing is the nsIAnonymousContentCreator documentation about
> filters.

I wouldn't like to copy possible values into nsIAnonymousContentCreator from nsIContent, therefore I jsut refer to nsIContent::GetChildren there. Any ideas?

Comment 13

[Boris Zbarsky [:bzbarsky]]

That looks good to me.

Comment 14

[alexander :surkov (:asurkov)]

landed on 2.0 - http://hg.mozilla.org/mozilla-central/rev/16ef018faad1