615781 - "ASSERTION: frame must not be dirty" (nsIFrame::GetCaretBaseline) after turning a textbox into a radio button

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Jesse Ruderman]

Attachment: testcase

###!!! ASSERTION: frame must not be dirty: '!NS_SUBTREE_DIRTY(this)', file layout/forms/nsFormControlFrame.cpp, line 93

ehsan, you fixed the last few of these ;)

Comment 1

[Jesse Ruderman]

Attachment: stack trace

Comment 2

[(no longer active)]

Hmm, nsFocusManager::SetCaretVisible first calls SetCaretDOMSelection <http://mxr.mozilla.org/mozilla-central/source/dom/base/nsFocusManager.cpp#2039> and then shows/hides the caret.  SetCaretDOMSelection calls StopBlinking and StartBlinking if mVisible.  But if aVisible is false in SetCaretDOMSelection, that StartBlinking call is unneeded, right?

So, roc, what do you think about extending SetCaretDOMSelection with a parameter calls aWillBeVisible or something like that, and only call StartBlinking if aWillBeVisible?

Comment 3

[(no longer active)]

Attachment: Patch (v1)

This implements comment 2.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Can't we just hide the caret before moving it so mVisible is false?

Comment 5

[(no longer active)]

Attachment: Patch (v2)

(In reply to comment #4)
> Can't we just hide the caret before moving it so mVisible is false?

Yes, probably a better idea.  Thanks for suggesting it.

Comment 6

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/c5e63ee00132