660200 - Intermittent failure in content/html/content/test/test_bug514437.html | [SimpleTest/SimpleTest.js, window.onerror] An error occurred - onFormSubmission is not defined

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Mounir Lamouri (:mounir)]

Mounir, please stop writing flaky tests!

s: talos-r3-xp-038
56296 ERROR TEST-UNEXPECTED-FAIL | /tests/content/html/content/test/test_bug514437.html | [SimpleTest/SimpleTest.js, window.onerror] An error occurred - onFormSubmission is not defined at http://mochi.test:8888/tests/content/html/content/test/test_bug514437.html:1

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1306491100.1306492880.2737.gz&fulltext=1

Comment 1

[Mounir Lamouri (:mounir)]

Sorry Mounir, I'm on it! :(

Comment 2

[Henri Sivonen (:hsivonen)]

<iframe name="submit_frame" onload="onFormSubmission();" style="visibility: hidden;"></iframe> before the declaration of onFormSubmission() is badness.

Comment 3

[Mounir Lamouri (:mounir)]

(In reply to comment #2)
> <iframe name="submit_frame" onload="onFormSubmission();" style="visibility:
> hidden;"></iframe> before the declaration of onFormSubmission() is badness.

Indeed. And even more because I only want onForSubmission() to be called after form.submit().

Comment 4

[Mounir Lamouri (:mounir)]

Attachment: Patch v1

Comment 5

[(no longer active)]

Comment on attachment 535613 [details] [diff] [review]
Patch v1

Mounir, thanks for quickly fixing this flaky test!  :-)

Comment 6

[Legacy TBPL/Treeherder Robot]

Ms2ger%gmail.com
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1306746326.1306747464.29591.gz
Rev3 WINNT 5.1 mozilla-central opt test mochitests-1/5 on 2011/05/30 02:05:26

s: talos-r3-xp-016
56294 ERROR TEST-UNEXPECTED-FAIL | /tests/content/html/content/test/test_bug514437.html | [SimpleTest/SimpleTest.js, window.onerror] An error occurred - onFormSubmission is not defined at http://mochi.test:8888/tests/content/html/content/test/test_bug514437.html:1

Comment 7

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/12ee31e36c0f