677859 - Stop using abDirTreeOverlay

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

Description

[[e-mail]]

abDirTreeOverlay still contains some RDF cruft. We should merge the bits we need (some of the attributes, the column header, and the treechildren element) into addressbook and then remove all references to it. Then we can file a bug on Thunderbird to completely remove it from the codebase.

Comment 1

[Ian Neal]

Attachment: Fold in abDirTreeOverlay [Checked in: Comment 3]

This patch:
* Removes references to abDirTreeOverlay.xul from all suite files.
* Folds in relevant parts of abDirTreeOverlay.xul into suite's addressbook.xul
* Adds relevant entity to abMainWindow.dtd
* Removes locale file abDirTreeOverlay.dtd and suite references to it.

Comment 2

[[e-mail]]

Comment on attachment 558670 [details] [diff] [review]
Fold in abDirTreeOverlay [Checked in: Comment 3]

>+      <tree id="dirTree"
>+            class="abDirectory plain"
>+            seltype="single"
>+            style="min-width:150px"
>+            flex="1"
>+            persist="width"
>+            hidecolumnpicker="true"
>+            context="dirTreeContext"
>+            onselect="DirPaneSelectionChange(); document.commandDispatcher.updateCommands('addrbook-select');"
>+            ondblclick="DirPaneDoubleClick(event);"
>+            onclick="DirPaneClick(event);"
>+            onblur="goOnEvent(this,'blur');">
Nit: could clean up the formatting (space after : and ,)

>+                   ignoreincolumnpicker="true"/>
Probably don't need that if we're hiding the columnpicker ;-)

Comment 3

[Ian Neal]

Comment on attachment 558670 [details] [diff] [review]
Fold in abDirTreeOverlay [Checked in: Comment 3]

With changes as suggested:
http://hg.mozilla.org/comm-central/rev/481444f2b269