68072 - Repaint fails after resize

Status: VERIFIED FIXED

(Core :: Layout, defect, P3)

Description

[dbialac]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Macintosh; U; BeOS; en-US; 0.7) Gecko/20010110
BuildID:    20001011014

"New" regions of the browser exposed by a resize are not drawn.  Instead, noise
appears.  This includes resizing the browser or collapsing the side bar.
Restarting the browser in the new dimmensions eliminates the problem.

Reproducible: Always
Steps to Reproduce:
Open mozilla, make window bigger.  Render any page (including the current).
Nothing appears in the regions added.

Actual Results:  New regions did not render parts of the pages that belonged
there.  Instead, "noise" shows up.

Expected Results:  Page should have rendered in new region

Comment 1

[Doron Rosenberg (IBM)]

your build is pretty old, could you please try a new nightly @ 
http://bezilla.inetking.com/?

Comment 2

[kurros (Wade Majors)]

Confirming

Comment 3

[Asa Dotzler [:asa]]

reassign

Comment 4

[karnaze (gone)]

Seawood, do you know who this should go to?

Comment 5

[cls]

Well, Yannick volunteered to be our resident BeOS contact person but I haven't
heard from him lately.  I guess I can hold onto it until he surfaces.

Comment 6

[Makoto Hamanaka]

Hi, I found the cause of this bug, finally!
In nsDrawingSurfaceBeOS.cpp::Init(BView *aView, PRUint32 aWidth, PRUint32 aHeight, 
PRUint32 aFlags) , it ignored the aWidth and aHeight parameter and using the size of aView
instead, to determine the size of offscreen bitmap, and I think it is wrong.

I made two patch ( -u and -uw ), so please review.

Comment 7

[Makoto Hamanaka]

Attachment: (cvs diff -u) patch to gfx/src/beos/nsDrawingSurfaceBeOS.cpp, this patch also removes some inconsistancy of indentation

Comment 8

[Makoto Hamanaka]

Attachment: (cvs diff -uw) patch to gfx/src/beos/nsDrawingSurfaceBeOS.cpp, for easy review

Comment 9

[cls]

Looks good to me (and thanks for providing the -uw diff :). r=cls

Comment 10

[Asa Dotzler [:asa]]

a= [e-mail] for checkin to the trunk.
(on behalf of drivers)

Comment 11

[cls]

Patch has been checked in.

Comment 12

[Chris Petersen]

Not sure if this is a Be OS issue only. Reporter, please check with a newer
build to see if problem has been resolved.

Comment 13

[dbialac]

I checked this on the latest available stable snapshot (0.9.1 I think), and the
refresh occurs slowly, but correctly.  While resizing you still get
noise/artifacts, but they disappear after you finish with the resize.  I do not
have this issue with the builds for Solaris and Windows.

Comment 14

[Chris Petersen]

Marking verified per last comments