Closed
Bug 708838
Opened 14 years ago
Closed 14 years ago
Fix js1_8/extensions/regress-422269.js to use findReferences instead of failing randomly
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla11
People
(Reporter: jimb, Assigned: jimb)
References
Details
Attachments
(1 file)
The SpiderMonkey test js/src/tests/js1_8/extensions/regress-422269.js fails
randomly, because it requires a certain object to be garbage-collected to
pass. With a conservative stack scanner, an object being retained is not
necessarily a bug, and in general, the engine makes no promises about which
objects it retains and which it doesn't.
The JavaScript shell's new findReferences function allows us to find all GC
edges referring to the object, and filter out ones we know to be benign.
This patch changes the test to use findReferences.
Attachment #580188 -
Flags: review?(jwalden+bmo)
|
||
Updated•14 years ago
|
Attachment #580188 -
Flags: review?(jwalden+bmo) → review+
|
Assignee | |
Comment 1•14 years ago
|
||
Flags: in-testsuite+
OS: Linux → All
Hardware: x86_64 → All
Target Milestone: --- → mozilla11
|
||
Comment 2•14 years ago
|
||
Assignee: general → jimb
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•