725702 - Reflect.parse should handle for-of loops correctly

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jason Orendorff [:jorendorff]]

js> Reflect.parse("for (x of y) z();").body[0].type
  "ForInStatement"

Whoops!

Comment 1

[:Benjamin Peterson]

Attachment: for of support

Comment 2

[Dave Herman [:dherman]]

Comment on attachment 641272 [details] [diff] [review]
for of support

>+    bool forOfOrIn(ParseNode *loop, ParseNode *head, Value var, Value stmt, Value *dst);

This name kinda bugs me, but I can't think of a better name.

r=me

Comment 3

[:Benjamin Peterson]

(In reply to Dave Herman [:dherman] from comment #2)
> Comment on attachment 641272 [details] [diff] [review]
> for of support
> 
> >+    bool forOfOrIn(ParseNode *loop, ParseNode *head, Value var, Value stmt, Value *dst);
> 
> This name kinda bugs me, but I can't think of a better name.

The name of the function or some argument name?

> 
> r=me

Comment 4

[Dave Herman [:dherman]]

The name of the function. Seems like there should be some technical term for "higher-level loops that iterate over objects" but I don't have one. So forOfOrIn is probably fine.

Dave

Comment 5

[David Zbarsky (:dzbarsky)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3b72e384d1bf

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Please remove checkin-needed when landing checkin-needed bugs.

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/3b72e384d1bf