Closed
Bug 726507
Opened 14 years ago
Closed 14 years ago
HTML and XUL accessible classes shouldn't use nsAccessibilityService::GetAccessible
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla13
People
(Reporter: surkov, Assigned: joey.blacksmith)
References
Details
(Keywords: access, Whiteboard: [good first bug][mentor=surkov.alexander@gmail.com][lang=c++])
Attachments
(1 file, 1 obsolete file)
|
3.17 KB,
patch
|
surkov
:
review+
|
Details | Diff | Splinter Review |
search through html and xul folders (http://mxr.mozilla.org/mozilla-central/source/accessible/src/) for GetAccService()->GetAccessible( and replace all calls on mDoc->GetAccessible(
|
Reporter | |
Updated•14 years ago
|
Attachment #596950 -
Flags: review?(surkov.alexander)
|
|
Reporter | |
Comment 2•14 years ago
|
||
Comment on attachment 596950 [details] [diff] [review]
First version of patch.
Review of attachment 596950 [details] [diff] [review]:
-----------------------------------------------------------------
::: accessible/src/html/nsHTMLSelectAccessible.cpp
@@ +436,5 @@
> content = content->GetParent();
> }
>
> if (content) {
> + nsAccessible* selAcc = mDoc->GetAccessible(content, nsnull);
nsDocAccessible doesn't take two arguments
Attachment #596950 -
Flags: review?(surkov.alexander) → review-
|
|
Reporter | |
Updated•14 years ago
|
Assignee: nobody → joey.blacksmith
Status: NEW → ASSIGNED
Attachment #596950 -
Attachment is obsolete: true
Attachment #596994 -
Flags: review?(surkov.alexander)
|
|
Reporter | |
Comment 4•14 years ago
|
||
Comment on attachment 596994 [details] [diff] [review]
Patch - Second version
Review of attachment 596994 [details] [diff] [review]:
-----------------------------------------------------------------
r=me
Attachment #596994 -
Flags: review?(surkov.alexander) → review+
|
|
Reporter | |
Comment 5•14 years ago
|
||
|
||
Comment 6•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in
before you can comment on or make changes to this bug.
Description
•