730782 - Firebug causes some kind of leak regarding decoded-video when refreshing page

Status: RESOLVED FIXED

(WebExtensions :: General, defect)

Description

[Riccardo Magliocchetti]

User Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:10.0.2) Gecko/20100101 Firefox/10.0.2 Iceweasel/10.0.2
Build ID: 20120217213059

Steps to reproduce:

1. open http://people.mozilla.com/~prouget/demos/mashup/video.xhtml
2. wait 5 sec
3. refresh page




Actual results:

When i open about:memory i see that after each refresh ~10MB of memory goes under media/decoded-video:.

├──224.26 MB (55.94%) -- media
│  ├──222.66 MB (55.54%) -- decoded-video
│  └────1.60 MB (00.40%) -- (1 omitted)

Firebug shows that only metadata has been requested and a handful of KB downloaded.

While this may look like an artificial behaviour this is an extreme version of what you do when doing frontend development, after a morning of work you have firefox consuming GBs of memory.

The memory consumed looks related to the size of video, another url with a bigger video increase the size ~30MB each refresh.




Expected results:

Some of the memory should be freed.

Comment 1

[Matthew Gregan [:kinetik]]

What happens when you click the "GC" button in about:memory?

Comment 2

[Riccardo Magliocchetti]

Ah! the issue happens only with firebug opened, without firebug running the media stuff get properly freed without calling GC manually. On the other hand if i close the tab which had firebug running the stuff is still lost, calling GC does not help.

Comment 3

[Boaz Dodin]

Riccardo, what Firebug version is in use?

Comment 4

[Riccardo Magliocchetti]

(In reply to Boaz Dodin from comment #3)
> Riccardo, what Firebug version is in use?

1.9.1b1

Comment 5

[Boaz Dodin]

(In reply to Riccardo Magliocchetti from comment #4)
> (In reply to Boaz Dodin from comment #3)
> > Riccardo, what Firebug version is in use?
> 
> 1.9.1b1

Although the changelog of final 1.9.1 version seems no relevant to this issue, can you please confirm the leak on 1.9.1?

Comment 6

[Riccardo Magliocchetti]

(In reply to Boaz Dodin from comment #5)
> (In reply to Riccardo Magliocchetti from comment #4)
> > (In reply to Boaz Dodin from comment #3)
> > > Riccardo, what Firebug version is in use?
> > 
> > 1.9.1b1
> 
> Although the changelog of final 1.9.1 version seems no relevant to this
> issue, can you please confirm the leak on 1.9.1?

Confirm same behaviour with 1.9.1.

Comment 7

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Riccardo, could you please test with Firebug 1.10a4
http://getfirebug.com/releases/firebug/1.10/firebug-1.10.0a4.xpi

One memory leaks (not sure if related) is fixed in this version

Honza

Comment 8

[Riccardo Magliocchetti]

(In reply to Jan Honza Odvarko from comment #7)
> Riccardo, could you please test with Firebug 1.10a4
> http://getfirebug.com/releases/firebug/1.10/firebug-1.10.0a4.xpi
> 
> One memory leaks (not sure if related) is fixed in this version

This makes a difference, thanks. Now it looks like that all but one are freed, there is still some memory used in that compartment after all tabs with a video and firebug are closed. If i press GC still ff is not able no reclaim that memory.

Comment 9

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Riccardo Magliocchetti from comment #8)
> This makes a difference, thanks. Now it looks like that all but one are
> freed, there is still some memory used in that compartment after all tabs
> with a video and firebug are closed. If i press GC still ff is not able no
> reclaim that memory.
Yep, I see that too. It looks like Firebug is keeping reference to the last page (in this particular case)

If you open another page and Firebug on it + refresh,
do you still see your compartment?

Honza

Comment 10

[Riccardo Magliocchetti]

(In reply to Jan Honza Odvarko from comment #9)
> (In reply to Riccardo Magliocchetti from comment #8)
> > This makes a difference, thanks. Now it looks like that all but one are
> > freed, there is still some memory used in that compartment after all tabs
> > with a video and firebug are closed. If i press GC still ff is not able no
> > reclaim that memory.
> Yep, I see that too. It looks like Firebug is keeping reference to the last
> page (in this particular case)
> 
> If you open another page and Firebug on it + refresh,
> do you still see your compartment?

I don't, if i open firebug on another page the video compartment gets freed without even calling manual GC.

Comment 11

[Jan Honza Odvarko [:Honza] (always need-info? me)]

I need bug 722749 to find and fix the problem.
Honza

Comment 12

[Jorge Villalobos [:jorgev] (he/him)]

Is this bug fixed with the fix for bug 695480? Can someone reproduce this in the latest nightly?

Comment 13

[Jorge Villalobos [:jorgev] (he/him)]

Ricardo, can you test this on Firefox 15 (Aurora at the moment) and see if the bug can still be reproduced?

Comment 14

[Riccardo Magliocchetti]

(In reply to Jorge Villalobos [:jorgev] from comment #13)
> Ricardo, can you test this on Firefox 15 (Aurora at the moment) and see if
> the bug can still be reproduced?

Yes, issue is still here.

Comment 15

[Andrew Williamson [:eviljeff]]

Ricardo, do you still experience this with the latest version of Firebug (1.10.0)?

I just tried now on Firefox 14 and, after pressing minimize memory usage, the memory was released.

Comment 16

[Riccardo Magliocchetti]

(In reply to Andrew Williamson [:eviljeff] from comment #15)
> Ricardo, do you still experience this with the latest version of Firebug
> (1.10.0)?
> 
> I just tried now on Firefox 14 and, after pressing minimize memory usage,
> the memory was released.

It looks like the reference leak in firebug has been fixed since the video compartment is reclaimed by the GC without manual intervention after the relevant is closed (ff 14, firebug 1.10.0). Good job! Thanks a lot

Riccardo (with the double c :)