752150 - "ASSERTION: scope has non-empty map" with SVG, embed, adoptNode

Status: RESOLVED DUPLICATE of bug 752340

(Core :: XPConnect, defect)

Description

[Jesse Ruderman]

Attachment: testcase (triggers assertions during shutdown GC)

###!!! ASSERTION: scope has non-empty map: '0 == mWrappedNativeMap->Count()', file js/xpconnect/src/XPCWrappedNativeScope.cpp, line 298

Comment 1

[Jesse Ruderman]

Attachment: stack trace

Comment 2

[Daniel Veditz [:dveditz]]

bholley: is this a bad assertion, or more of a warning?

Comment 3

[Bobby Holley (:bholley)]

(In reply to Daniel Veditz [:dveditz] from comment #2)
> bholley: is this a bad assertion, or more of a warning?

Hard to say. Seems like more of a warning (in the sense that nothing bad is about to happen right at that second). But it also means there's probably a WN floating around with a garbage scope pointer.

adoptNode and wrapper reparenting are already all kinds of broken after CPG (see bug 751995 and bug 752038). So let's wait until those are fixed and see if this still appears. If it does, we should probably fix it.

Comment 4

[David Bolter [:davidb] (NeedInfo me for attention)]

Adding 751995 and 752038 as potential dependencies as per comment 3.

Comment 5

[Andrew McCreight [:mccr8]]

I checked this test case on a local build from 6/9, and the assertion is still triggering, so it sounds like neither of those bugs fixed this.

Comment 6

[Andrew McCreight [:mccr8]]

This seems to work for me with a local build now.  Somebody should double check that.

Comment 7

[Jesse Ruderman]

I'm still getting the assertion on Mac, both with a local build and with a Tinderbox debug build.

Comment 8

[Andrew McCreight [:mccr8]]

I guess I failed to rebuild after popping my patch for bug 752340.

Anyways, looks like this is a dupe of bug 752340.  No assertion with my patch for that bug applied, and without that patch, it triggers an assertion from a local patch I have that checks to make sure both objects being swapped agree on finalizer-ness.