762739 - Builtin media controls on B2G should have a way of going to fullscreen

Status: RESOLVED WORKSFORME

(Core :: Audio/Video, defect, P2)

Description

[[e-mail] [:onecyrenus]]

Generally there needs to be a fullscreen button attached to the content, so the user can watch the video in fullscreen mode. 

Currently this is how things are done in android.

Comment 1

[cajbir (:cajbir)]

How do the android controls do fullscreen? I copied the b2g controls from android and didn't notice it.

Comment 2

[[e-mail] [:onecyrenus]]

So I noticed there is a toggle on the bottom right hand corner of the video, when you click it it goes fullscreen.  

I don't know at what level it is provided in android, but it is there.

Comment 3

[Andreas Gal :gal]

How are we doing here?

Comment 4

[Andreas Gal :gal]

Renom if you think we can't ship a v1 without this.

Comment 5

[Jason Smith [:jsmith]]

Per IRC conversations with a few other folks, I think the best course of action if there is disagreement on whether this blocks or not is to do the following:

- Move the blocking-basecamp flag to ? for re-evaluation
- Indicate a rationale for why you disagree

Comment 6

[Lawrence Mandel [:lmandel] (use needinfo)]

Alternatively, if this doesn't block, let's set blocking-basecamp-

Comment 7

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Given that this can be worked around by websites, and likely doesn't even affect most video websites since they use their own controls, I'd say this isn't blocking.

Comment 8

[cajbir (:cajbir)]

B2G media controls have full screen now.