764698 - Fix distinguishability checking for dictionaries

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

I failed to do this right in bug 742153.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix isDistinguishableFrom for dictionaries to work right.

While writing this, I discovered that isCallback() is false in IDLWrapperType (which makes sense) but that we had consumers checking isCallback() on types and assuming that would catch callback interfaces.  So I added better ways of testing for that and used them throughout.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix isDistinguishableFrom for dictionaries to work right.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 634275 [details] [diff] [review]
Fix isDistinguishableFrom for dictionaries to work right.

Peter, Kyle is apparently swamped again.  Could you take a look?  I mostly want this because it cleans up the callback stuff a lot...  Kyle did already OK the general idea.

Comment 4

[Peter Van der Beken [:peterv]]

Comment on attachment 634275 [details] [diff] [review]
Fix isDistinguishableFrom for dictionaries to work right.

Review of attachment 634275 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bindings/parser/WebIDL.py
@@ +1267,5 @@
>          if other.isPrimitive() or other.isString() or other.isEnum():
>              return True
> +        if self.isDictionary():
> +            return (other.isNonCallbackInterface() or other.isSequence() or
> +                    other.isArray())

or isDate()?

Comment 5

[Boris Zbarsky [:bzbarsky]]

> or isDate()?

Yes, good catch.  That column was off the right edge of my browser viewport.  ;)

Comment 6

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/da942dd41b43

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/da942dd41b43