768924 - MediaEngineDefault.cpp:236:12: warning: converting to non-pointer type ‘nsresult {aka unsigned int}’ from NULL [-Wconversion-null]

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Daniel Holbert [:dholbert]]

{
mozilla/content/media/MediaEngineDefault.cpp:236:12: warning: converting to non-pointer type ‘nsresult {aka unsigned int}’ from NULL [-Wconversion-null]
mozilla/content/media/MediaEngineDefault.cpp:241:12: warning: converting to non-pointer type ‘nsresult {aka unsigned int}’ from NULL [-Wconversion-null]
}

Code snippet:

232 nsresult
233 MediaEngineDefaultAudioSource::Start(SourceMediaStream* aStream, TrackID aID)
234 {
235   if (mState != kAllocated) {
236     return NULL;
237   }
238 
239   mTimer = do_CreateInstance(NS_TIMER_CONTRACTID);
240   if (!mTimer) {
241     return NULL;
242   }
243 
http://mxr.mozilla.org/mozilla-central/source/content/media/MediaEngineDefault.cpp?mark=232-232,236-236,241-241#232

Not sure what we want to return here, but NULL is not correct, as it's not a nsresult.

Comment 1

[Daniel Holbert [:dholbert]]

(This is in a new file added a few weeks ago in bug 752351, "Implement fallback MediaEngine backend")

Comment 2

[Anant Narayanan [:anant]]

I fixed this in the first patch for bug 691234, but I'll leave this bug open until it has been reviewed and landed.

Comment 3

[:Cykesiopka]

The fix in Bug 691234 landed and still seems to be in the file, so marking as fixed.