773911 - Inline js::GetContextCompartment

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Would make checks that stuff is in the right compartment faster.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Inline js::GetContextCompartment.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Use the now-inline js::GetContextCompartment in a few places.

Comment 3

[Jeff Walden [:Waldo]]

Comment on attachment 690034 [details] [diff] [review]
part 1.  Inline js::GetContextCompartment.

Review of attachment 690034 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jspubtd.h
@@ +271,2 @@
>      ContextFriendFields(JSRuntime *rt)
> +        : runtime(rt), compartment(NULL) { }

This was correctly indented two spaces.  {} really belongs on a new line, tho, if we're going to touch anything here.

Comment 4

[Jeff Walden [:Waldo]]

Comment on attachment 690035 [details] [diff] [review]
part 2.  Use the now-inline js::GetContextCompartment in a few places.

Review of attachment 690035 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me

Comment 5

[Boris Zbarsky [:bzbarsky]]

   https://hg.mozilla.org/integration/mozilla-inbound/rev/79c26e82dfeb
   https://hg.mozilla.org/integration/mozilla-inbound/rev/ea066846993c

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/79c26e82dfeb
https://hg.mozilla.org/mozilla-central/rev/ea066846993c